Skip to content

ci: let the dependency audit fail #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattglory merged 1 commit into from
Sep 22, 2026
+5 −2
Merged

ci: let the dependency audit fail #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,16 @@ jobs:
with:
node-version: "20"

# No continue-on-error: this step must be able to fail. It used to be set,
# which made the job pass unconditionally -- PR #61's run printed several
# "Severity: high" findings and the job still concluded success. A check that
# can't go red isn't evidence of anything. Dependency Audit is not a required
# status check, so a red run here never blocks a merge; it is a signal.
- name: Audit root dependencies
run: npm audit --audit-level=high
continue-on-error: true

- name: Audit web dependencies
run: cd web && npm audit --audit-level=high
continue-on-error: true

codeql:
name: CodeQL Analysis
Expand Down
Loading