Add the codex review wrapper [ignore_release] - #147
Draft
snake14 wants to merge 1 commit into
Draft
Conversation
Points at the shared workflow in plugin-ci-workflows rather than the private one: GitHub resolves a reusable workflow from the callee repository access policy at parse time, so a public caller cannot be granted access to a private repository. The wrapper is label-gated and does nothing until the codex-review label is added.
snake14
marked this pull request as draft
September 13, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Important
Blocked on repository access to the shared credentials, not on this change. The shared workflow declares its two secrets as required, and they are not available to this repository yet. Merging before that is granted would be worse than leaving it: a missing required secret fails at workflow-call validation with zero jobs and no comment, and leaves the trigger label stuck on, which reads as a broken review rather than a missing credential. This stays a draft until the access is in place.
Adds the
codex-reviewwrapper so this plugin can be reviewed by Codex, bringing it in line with the plugins that already have one.The wrapper points at
matomo-org/plugin-ci-workflows/.github/workflows/plugin-codex-review.yml, the public shared workflow, rather than the private one some older callers use. GitHub resolves a reusable workflow from the callee repository's Actions access policy at parse time, before any job or secret exists, so a public repository cannot be granted access to a private one — it fails with "workflow was not found" and zero jobs, and no token or setting changes that. The shared workflow is the job structure that policy permits; the review logic stays private and is checked out withTESTS_ACCESS_TOKEN.It triggers on
pull_request_target: [labeled]and is gated on thecodex-reviewlabel, so it does nothing until someone adds that label. The job-levelifis deliberate rather than redundant: without it, adding any label would instantiate the shared workflow, claim itscancel-in-progressconcurrency group, and cancel a review already running on the same pull request.Two things worth knowing about when it becomes usable:
pull_request_targetonly fires from the default branch's copy of a workflow, so this does nothing until it is merged — a repository whose default branch moved has silently dead codex review until the wrapper lands there.No version bump or changelog entry: this is CI configuration only.
Issue No
No GitHub issue.
Steps to Replicate the Issue
codex-reviewlabel to a pull request in this repository.Checklist