Skip to content

Move the checks onto the shared umbrella and build the other dev branch weekly [ignore_release] - #285

Merged
snake14 merged 3 commits into
6.x-devfrom
weekly-ci-migration
Sep 11, 2026
Merged

snake14 merged 3 commits into
6.x-devfrom
weekly-ci-migration

Conversation

@snake14

@snake14 snake14 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description

Three separate changes, one per commit so any can be reverted on its own.

The pull request checks move behind the shared umbrella. The workflows this replaces were already thin callers of the same shared workflows, so what changes is that one caller invokes them rather than several. The point is that a check added centrally now reaches this plugin without a pull request here. It also drops the concurrency group the AI checklist workflow carried — that group spans both of the umbrella's lanes and silently defeats them, which the shared workflow now fails the run on.

The non-default dev branch gets a weekly build. GitHub only runs a schedule trigger from the default branch's copy of a workflow file, so when the default moved the other line stopped being built and nothing said so. The sweep dispatches this plugin's own matomo-tests.yml on that branch using this repository's own token — workflow_dispatch is a documented exception to the rule that GITHUB_TOKEN-triggered events create no workflow run, so no PAT is involved. The cron keeps this plugin's own minute and hour, moved to Sunday, so it does not compete with the Saturday build and the fleet keeps its stagger.

The pre-push hook is re-synced to the canonical copy, and verify-hook: true turns on the check that keeps it there. The local copy had drifted well behind — it predates the fix for PHPStan exiting 1 when a plugin's config excludes every changed file, so a test-only push was rejected. The flag and the re-sync are in one commit deliberately: enabling the check against a drifted copy would just go red.

Verified live on matomo-org/plugin-LogViewer and innocraft/plugin-UsersFlow: a manual dispatch resolved the default branch, dispatched the build on the other one, and that build completed green attributed to that branch — which is what the plugin build dashboard's per-branch badges read.

Issue No

No GitHub issue.

Steps to Replicate the Issue

  1. Note that this repository's default branch is 6.x-dev, so the matomo-tests.yml cron only ever fires there.
  2. Expected result: the other maintained dev branch is built weekly too.
  3. Actual result: it has had no scheduled build since the default branch changed.

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [NA] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

The callers this replaces were already thin wrappers around the same shared workflows, so one caller means a check added centrally reaches this plugin without a pull request here. It also drops the concurrency group the checklist workflow carried, which would span both of the umbrella's lanes and defeat them.
GitHub runs `schedule` only from the default branch's copy of a workflow, so the other maintained branch has had no weekly build of its own. The cron keeps this plugin's own minute and hour, moved to Sunday, so the fleet stays staggered.
The local copy had drifted behind the canonical one, which predates the fix for PHPStan exiting 1 when a plugin's config excludes every changed file. verify-hook only becomes safe once the copy matches.
@snake14
snake14 requested a review from a team September 11, 2026 01:56
@snake14
snake14 merged commit 7eb6c23 into 6.x-dev Sep 11, 2026
22 of 23 checks passed
@snake14
snake14 deleted the weekly-ci-migration branch September 11, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants