Skip to content

Complete matrix.mac migration to maximasrc - #1909

Merged
sangwinc merged 2 commits into
iss1905from
iss1908
Oct 14, 2026
Merged

sangwinc merged 2 commits into
iss1905from
iss1908

Conversation

@adamant-pwn

Copy link
Copy Markdown
Collaborator

Move the rest of matrix.mac into maximasrc: matrix operations, the remaining predicates, and equation-display functions. They become available in core STACK, with co-located tests and generated documentation. Existing matrix.mac includes retain their c/r declaration.

Also fixes existing bugs exposed by the migration:

  • Orthogonality checks overwrite M and checkmat; localising them also makes orth_matrixp reject non-matrix lists as documented.
  • Equation-display functions overwrite eqns and helper-function definitions.
  • mat_disp_eqns fails for a single equation because Maxima collapses its intermediate 1×1 matrix to a scalar.

Correct stale TeX test expectations and document the existing limits on empty matrices.

Stacked on #1906, targeting iss1905. This completes matrix.mac; other contributed libraries and the proposed row_vector/column_vector API remain separate.

Closes #1908.

@adamant-pwn
adamant-pwn added this pull request to stack #1907 October 14, 2026 01:00
@sangwinc

Copy link
Copy Markdown
Member

Thanks @adamant-pwn for all your work rearranging and improving this!

@sangwinc
sangwinc merged commit bb2a399 into dev Oct 14, 2026
9 of 10 checks passed
@sangwinc
sangwinc deleted the iss1908 branch October 14, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants