Repository navigation
Fix TODO page in STACK question dashboard for Moodle 5 - #1899
Merged
Merged
Conversation
Member
|
Thank you @ngandrass that's very helpful indeed. We're about to make a new release, so it will find its way into master very soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Moodle 5, accessing the "Find [[todo]] blocks" page (
adminui/todo.php) from the STACK question dashboard throws the followingcodingerror:Moodle 5 changed the context in which question live. Due to the missing
$PAGE->set_cm()call, the page now fails to build the header navigation and throws the exception seen above.Applying the workaround introduced by fa00b15 to other adminui pages, i.e.
adminui/bulktest.php, fixes this issue while maintaining full compatibility with Moodle 4.This PR also fixes the previously incorrectly set page URL while keeping the passed
contextid.