Repository navigation
Resolve output references used as dictionary keys - #894
Open
CAOShurong wants to merge 1 commit into
Open
CAOShurong wants to merge 1 commit into
CAOShurong wants to merge 1 commit into
Conversation
Member
|
Hi @CAOShurong, thank you for this. Are you able to resolve the conflicts with the existing branch? Note, we have just merged #870 which may overlap here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OutputReferenceobjects used as dictionary keys as well as valuesrun_locallyregression coverage for BUG: Dictionaries with output references as keys do not resolve #838Fixes #838.
Additional dependencies introduced (if any)
None.
TODO (if any)
None.
Checklist
pre-commitpasses).Verification
pytest tests/core/test_reference.py tests/managers/test_local.py::test_output_reference_as_dictionary_key -q: 18 passedpytest -q: 140 passed, 8 skipped, 1 xfailed on a successful full run. A repeat encountered three Windows same-timestamp assertions in unrelated local-manager tests; two of the representative failures reproduced on the exact base commit.pre-commit run --files src/jobflow/core/reference.py tests/core/test_reference.py tests/managers/test_local.py: passedpython -m build: sdist and wheel built successfully{'text': 'c', 'test': 'text'}Disclosure: this pull request was prepared with assistance from OpenAI Codex; the implementation and verification evidence are provided here for maintainer review.