Lower insert throughput floor to 500/s to stop CI false failures - #43
Merged
Merged
Conversation
The Slow-suite gate in InsertThroughputTests required 800 inserts/s. The master push runs for #41 and #42 -- documentation and version-only changes -- failed at 711/s and 786/s while the PR runs of the same code passed a few minutes earlier. GitHub-hosted runners vary enough under load that an 800/s floor had only ~10 % headroom. 500/s still catches a regression to the pre-optimisation insert path (~450/s on a developer machine, roughly 225/s on a CI runner) with a wide margin. The comment records the measured CI values. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower insert throughput floor to 500/s to stop CI false failures
The Slow-suite gate in InsertThroughputTests required 800 inserts/s. The
master push runs for #41 and #42 -- documentation and version-only changes
-- failed at 711/s and 786/s while the PR runs of the same code passed a
few minutes earlier. GitHub-hosted runners vary enough under load that an
800/s floor had only ~10 % headroom.
500/s still catches a regression to the pre-optimisation insert path
(~450/s on a developer machine, roughly 225/s on a CI runner) with a
wide margin. The comment records the measured CI values.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com