Skip to content

chore: file agent feedback on define tag argument types - #610

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-persisted-pages-xh8764-define-args
Oct 15, 2026
Merged

DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-persisted-pages-xh8764-define-args

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Files agent-feedback items instead of a fix: <define> tag var calls fall to DefaultRenderer, so valid multi-argument calls report Expected 1 arguments and single arguments go unchecked. It also files three findings from investigating it: attribute tags after tag arguments typed against the wrong input, the per-call type cost of a single-object-param body, and the @marko/language-tools bench measuring nothing.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4c49278

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DylanPiercey
DylanPiercey merged commit c455e1f into main Oct 15, 2026
5 checks passed
@DylanPiercey
DylanPiercey deleted the dpiercey-ws-persisted-pages-xh8764-define-args branch October 16, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant