Repository navigation
fix: align with htmljs-parser 5.18 - #608
Conversation
Match htmljs-parser's operator rules in the grammar. A `!` directly after a word, `)` or `]` is a non-null assertion, so it no longer continues an attribute value, spread or tag variable type across whitespace; after a keyword operator (`typeof!`, `in!`) it is still the prefix `!`. In a tag variable's type `void` is the void type, so it neither continues the value nor takes the next attribute as its operand. `delete` joins the prefix keywords. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Match htmljs-parser: a `!` after another `!` (`x!!`) or after a closing quote or backtick (`"s"!`) is a non-null assertion, so it ends an attribute value, spread or tag variable type rather than continuing it as a prefix `!`. A `!!` after an operator still continues. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Raise the parser floor in language-tools and language-server to the release whose expression rules the grammar now follows, so the language server reads templates the same way the highlighting does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: d5fd054 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. WalkthroughThe language server and language tools now use Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The parser and highlighting updates match the stated changes, with no concrete regression evidenced. The PR appears mergeable subject to normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1 participant
Raises the htmljs-parser floor in language-tools and language-server to 5.18.0, which fixes several expression misparses: a type ending in
void, a TypeScript non-null assertion (x!) ending an unenclosed value,deleteas a prefix operator, and types in scriptlets.The VS Code grammar follows the same rules. A
!directly after an operand (x!,f()!,x!!,"s"!) ends an attribute value, spread or tag variable type instead of continuing it as a prefix!. In a tag variable's type,voidno longer takes the next attribute as its operand.delete xstays one value.🤖 Generated with Claude Code