Repository navigation
fix: keep the Marko prettier plugin under a project prettier config - #603
Merged
DylanPiercey merged 1 commit intoSep 23, 2026
Merged
DylanPiercey merged 1 commit into
DylanPiercey merged 1 commit into
Conversation
The formatter spread the project's resolved prettier config over its own options, so a config with `plugins` replaced the Marko plugin: "Format Document" failed with `Couldn't resolve parser "marko"`, and code-action fixes fell back to the compiler's unformatted reprint, which the code-action snapshots had recorded. The Marko plugin is now always kept, the config's plugins are resolved from the config file rather than the server's working directory, and one that cannot be loaded is skipped. The vscode tests also create their project inside the repo, so it resolves this repo's `marko` rather than whatever a `node_modules` above the system temp dir provides, with its own empty prettier config. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5a154b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open
DylanPiercey
deleted the
dpiercey-ws-prettier-marko-async-ulp3vg-hermetic-vscode-tests
branch
September 23, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter spread the project's resolved prettier config over its own options, so any config with
plugins(tailwind, packagejson, ...) replaced the Marko plugin: "Format Document" failed withCouldn't resolve parser "marko", and code-action fixes silently fell back to the compiler's unformatted reprint, which the code-action snapshots had recorded (eg<script >). Formatting now keeps the Marko plugin, resolves the config's plugins from the config file rather than the server's working directory, and skips one that cannot be loaded. The code actions share the same helper, and a new test formats against temp projects with a project-only plugin and a missing one.The vscode tests also create their project inside the repo instead of the system temp dir, where a
node_modulesabove it could supply a differentmarko(a Marko 6 there made thedefinitiontest fail, since it does not treatcomponents/as a tag directory).🤖 Generated with Claude Code