Recover historical message encodings in standalone backfill - #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offline backfill stopped on historical rows whose stored metadata differs from the original wire encoding. Recover expanded payload lengths, early root-form hashes with local parent links, literal recipient fields, and batch timestamps retained in exact wire headers. Reconstruct recorded received batches as well as locally sent batches.
Every existing SHA-256 must still match the complete reconstructed message. Ambiguous or irreproducible records stop the migration, and all changes roll back. These compatibility cases stay in the standalone maintenance binary; the daemon, API and bootstrap SQL are unchanged.
Validation: full Go race tests with PostgreSQL,
go vet ./...,go build ./..., and an offline audit of a restored legacy store. Regression tests cover each recovered encoding, rollback, and hash preservation.