feat(sms-bridge): configure optional Messaging Service delivery - #86
Merged
Conversation
Chart CI passedRepository hygiene and Helm validation passed. View the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release chart
opencode-sms-bridge0.1.3with a non-secretconfig.messagingServiceSidConfigMap value wired to the worker-onlyTWILIO_MESSAGING_SERVICE_SIDenvironment variable. Its default is empty, preserving existing direct-sender behavior until a consumer selects a real Terraform-created service SID.Fixes #
None — owner-approved A2P delivery remediation.
Type of change
Validation
chartsCI run 33983044194 passed test, package, and detect at the PR head.No local Helm rendering, packaging, Kubernetes, SOPS, or live Twilio operation was run or claimed.
Impact and rollout
Producer: this PR publishes immutable OCI chart version
0.1.3only after an explicitly approved merge and successfulmainpackage job.Consumers: the new value is worker-only and defaults to empty. It requires the companion bridge image PR and a separate
tfroot-twilioservice creation/apply.kustomize-clustermust later select the published chart/image and real service SID in one focused PR; no post-publish automation exists for this chart.Delivery stages: source authored and validated here; publication, provider service creation, manual A2P association, GitOps selection, reconciliation, health, and delivery verification remain separate gates.
Rollback: keep the consumer value empty or select the prior chart version through GitOps; do not patch a live Deployment or ConfigMap.
Safety and secrets
AI-assisted change: an OpenCode agent materially produced this change. Reviewers should verify the chart version bump, worker-only ConfigMap wiring, empty default, and unchanged secret/Argo boundaries.