Fix CI on pushes to main: scope asks for a pull request that is not there - #42
Merged
Merged
Conversation
… not there main has been red on every push since #38. The `scope` job reads the changed files from `repos/OWNER/REPO/pulls/NUMBER/files`, and on a push event `github.event.pull_request.number` is empty, so the request goes to `/pulls//files` and comes back 404. `scope` fails, every job that needs it is skipped, and the `ios` check reports the failure. #37 added `scope` for pull requests and #38 added the push trigger. Each was green on its own; the combination was never run before it was on main. A push has nothing to skip anyway. What reached main is worth building, and that run is the only thing that reports on it now that the required check cannot. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main has been red on every push since #38.
The
scopejob reads the changed files from the pull request. On a push eventgithub.event.pull_request.numberis empty, so the request goes to/pulls//filesand 404s.scopefails,packages/build/testare all skipped as a consequence, andiosreports the failure.#37 added
scopefor pull requests. #38 added the push trigger. Each was green on its own; the combination was never run before it was on main — #38 branched from main before #37 landed, so the two never met until the merge.A push has nothing to skip in any case: what reached main is worth building, and that run is now the only thing reporting on it.
🤖 Generated with Claude Code