Repository navigation
Remove unused I2C address probe helpers - #410
Merged
Merged
Conversation
_probe_i2c_addr and _wait_i2c_device_power lost their last caller when display-less board detection moved to M5GFX. Both are private, so removing them does not affect the public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_probe_i2c_addrand_wait_i2c_device_powerlost their last caller when display-less board detection moved to M5GFX. Both are private, so removing them does not affect the public API.Testing: builds for the ESP32 family on the Arduino and ESP-IDF versions used in CI, and native (SDL). Fork CI passed.