Repository navigation
Follow M5GFX: use getCandidateBoard, translate recent comments in Power_Class - #409
Merged
Merged
Conversation
The getter was renamed in M5GFX before release; requires the matching M5GFX.
Comments only; no code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
M5GFX::getBoardCandidate()togetCandidateBoard()(m5stack/M5GFX BMI270: report a failed config upload; PCF8563: setTimerIRQ rounding does not overflow #361). The getter has not been released, so nothing else changes.Power_Class.inlsince 0.2.26 to English (comments only).Requires that M5GFX change; the fork CI for this branch builds against M5GFX develop, so it fails on the undefined getter until the M5GFX PR is merged. Built locally with the M5GFX change for the upstream CI's chips and versions.