Repository navigation
Use the board detector for displayless boards - #396
Merged
Merged
Conversation
Remove the displayless fallback block from _check_boardtype(); the board detector now identifies those boards. M5Unified picks the board in this order: the detector's result, an explicit cfg.fallback_board, the detector's candidate, the remaining ESP32-P4 checks, then a build or package default (_default_fallback_board()). - Package defaults: StampPico (PICO-D4), AtomPsram (PICO-V3), TimerCam (D0WDQ6), StampS3 (S3 other than LGA56, previously AtomS3Lite), StampS3Mini (LGA56), StampC3U (C3), NanoC6 / StampC6 (C6), NanoH2 (H2), StampC5 (C5), Tab5 (P4). BOARD_ID 147 selects DualKey; BOARD_ID 31 / 35 select CoreP4X / Tab5X before the P4 GPIO checks. - cfg.fallback_board now defaults to board_unknown on every target. - Pin setup follows the chosen board, however it was chosen: GPIO46 is restored on S3 boards that use it, DualKey releases G7 / G8 and gets its own pin map, and Capsule sends the I2C STOP and releases its Grove port in its own setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires m5stack/M5GFX#342, which moves the identification of boards without a display into the board detector.
What changes
_check_boardtype()is removed.cfg.fallback_board, the detector's candidate (getBoardCandidate()), the remaining ESP32-P4 checks, then a build or package default (_default_fallback_board()).cfg.fallback_boardnow defaults toboard_unknownon every target. Setting it still forces the board when the detector cannot confirm one.Defaults when nothing is confirmed
BOARD_ID147 selects DualKey.BOARD_ID31 / 35 select CoreP4X / Tab5X before the P4 GPIO checks. On ESP32, an Arduino board macro now takes precedence over the package default.The S3 default changes because AtomS3Lite is now identified by its own pins, so a board that reaches the default is more likely a StampS3.
Tested
On 28 boards together with the M5GFX change (see that PR for the list). Builds: Arduino-ESP32 2.x / 3.x and ESP-IDF 5.x / 6.x for the CI targets.