Repository navigation
Warn about a disagreeing Tab5 hint on the recovery-candidate path - #344
Merged
Merged
Conversation
When the IO expanders do not answer, the Tab5 / Tab5X candidate chosen from the chip revision is what the caller uses, but only the confirmed path logged a saved hint that disagrees with the revision. Log it on the failed-confirm path as well, through one helper shared with confirm().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #343. When the Tab5 IO expanders do not answer, the Tab5 / Tab5X recovery candidate chosen from the chip revision is what the caller uses, but only the confirmed path logged a saved hint that disagrees with the revision. Log it on the failed-confirm path as well.
Changes
signature()andconfirm()share them.Tested