Repository navigation
Conversation
Added handling for InvalidDataException in portable settings initialization.
Add error handling for driver export failures.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


A follow-up to #470 with some smaller issues I found in the same pass. Each fix is a separate commit.
1. Crash on Shift+click of a column header after switching language (
MyObjectListView.cs,DSEForm.cs)Switching language calls
InitializeComponent()again, which creates a new list view.RestoreStateonly restores the primary sort column, soSecondarySortColumnis null on the new list andHandleColumnClickthrows aNullReferenceExceptionon Shift+click. The secondary sort column is now kept across the switch, and the click handler checks for null.2. App reopens minimized if it was closed while minimized (
DSEForm.cs)If you close it from the taskbar while it's minimized,
FormClosingsavesWindowState = Minimizedand the location (-32000, -32000), so the next start opens minimized. It now savesNormaland the restore position instead.3. "Copy folder path" crashes when the folder is unknown (
DSEForm.cs)With the PnpUtil backend, a package that can't be matched to a driver store folder has an empty
DriverFolderLocation.Clipboard.SetText("")throws, and "Open folder" runsexplorer /select, [Unknown], which opens Documents. Both menu items are now disabled when there's no folder.4. Add driver: the INF search can throw an unhandled exception (
DSEForm.cs)FindInfFile(...).ToList()runs before thetryblock, so an unreadable subfolder or a path that's too long in a deep driver bundle crashes the async handler. It now shows an error instead.5. Add driver: only the first INF in the selected folder is added (
DSEForm.cs)If the selected folder has INFs at the top level, only the first one is added. If it has none, the recursive search added in #437 adds all of them. So a folder with several INFs, which is common for chipset and audio packages, is only partly added unless you pick its parent. It now adds all the top-level INFs. This changes behavior, so let me know if taking only the first one was intentional and I'll drop this commit.
6. CSV export crashes on access denied (
DSEForm.cs)ExportDriverListcatchesIOExceptionandSecurityException, but saving over a read-only file throwsUnauthorizedAccessException. I added it to the filter.7. DISM: one unreadable driver folder breaks the whole list (
DismUtil.cs)GetFolderSizewas called without atry, so one missing or unreadable folder madeEnumeratePackagesfail and the list came up empty. It's now handled per package, likeNativeDriverStorealready does.