chore(semantics): refresh project registry I/O metadata - #4990
huangruiteng merged 3 commits into
Conversation
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
|
@huangruiteng Please review the refreshed manifest at exact head This branch now includes Exact-head local verification:
The previous Windows failure belonged to the superseded run and reproduced the two base issues fixed by #4986. The push started fresh DCO, dependency-review, release, and Python checks for this exact head. |
…-registry-io-manifest-0924 Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
huangruiteng
left a comment
There was a problem hiding this comment.
动机
#4990 修复 project registry I/O 架构清单与合并后源码不一致的问题。在精确基线 4a41193de827b48b4d09efb9b84f92366ae62a0b,同一生成器因 1 个未登记的 codec 读取点及 11 处位置漂移退出 1;该 PR 恢复现有门禁,不改变运行时 registry I/O。
改动思路
沿用源码 AST 扫描器生成站点、既有 manifest 保存分类、验证器比较两者的单一所有权。此次只将新增的 activation_service._projected_source_identity 的 load_registry 登记为 codec_api,并更新 11 个已有站点的派生位置;没有新增例外或第二套清单。
具体改动
关键代码讲解
loopx/semantics/project_registry_io_manifest_v1.json:新增上述读取点(源码第 91 行);其余 manager context、Chat、Goal activation、Lark 和 global registry 站点仅调整line/column。已有站点的 ID、API、kind 与 classification 不变。- 现有
build_project_registry_io_manifest仍从源码推导位置,validate_project_registry_io_manifest仍拒绝未登记站点或漂移。基线实际报出 1+11 项,新 head 的同一检查报告 232 sites current。
对主干的风险
PR 仅修改一个生成清单文件(+20/−12),不修改运行时调用或分类规则。独立检出运行生成器检查通过,相关架构测试 9 passed,git diff --check 通过;当前 origin/main 等于 PR 基线,git merge-tree 无冲突。未等待或采信 CI 作为本结论的依据。若合并前主干再移动源码站点,需要重跑生成器。
语义与 CI 对齐
继续复用 loopx_project_registry_io_manifest_v1 及 codec_api 词汇,未放宽“未分类直接 I/O”门禁。PR 正文仍写旧 head 的“四处/231 sites”,作者的 exact-head 评论已更新为 232;建议同步正文,避免后续审阅者误读。
我的整体评价
对精确 head 52c6bdf244c9de129f255544951fa91219c174d4 给出 APPROVE。基线失败与 head 通过形成直接对照;变更局限在既有生成物,毗邻边界已有集中生成器,无需额外重构或抽象。结论不覆盖未来的主干源码移动。
English verdict: APPROVE - exact head 52c6bdf; the canonical manifest now records 232 classified sites. The base check failed on one missing site and 11 location drifts; the head check and nine architecture tests passed. Please refresh the superseded PR description for clarity.
Summary
mainBaseline evidence
At exact base
4efafaf16b4fab1aa99e8e45d0aedb7a044820b2,test_checked_in_project_registry_io_manifest_is_currentreports four metadata drifts in manager context, Chat, and Lark team-plan reads. The repository generator reports 231 sites and 0 unclassified direct sites.Validation
python scripts/generate_project_registry_io_manifest.py --checkpytest -q tests/architecture/test_project_registry_io_census.py::test_checked_in_project_registry_io_manifest_is_current tests/architecture/test_goal_instance_binding_inventory.py(4 passed)git diff --checkThis PR contains no runtime behavior change.