Repository navigation
chore(deps): pin handlebars 4.7.10 via resolutions (fixes Audit on main) - #519
Merged
Merged
Conversation
`make audit` (yarn audit --level critical) fails on main since the two Handlebars advisories published with 4.7.10 (JS injection via AST type confusion; via own-property-check bypass). handlebars is a transitive dep of grpc_tools_node_protoc_ts and spectaql only; the existing `**/handlebars` resolution pinned 4.7.9. Bump it to 4.7.10. No runtime code path uses handlebars. Verified: `yarn audit --level critical` exit 14 (no critical) after the bump, 30 before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G4SaLJF5SWq6sjBEaWJFow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
Auditcheck (make audit=yarn audit --level critical) fails on every PR since the Handlebars 4.7.10 advisories were published (2026-10-05): JavaScript injection via AST type confusion, and via own-property-check bypass. Both are patched in >=4.7.10. Current main pins**/handlebarsto 4.7.9.What
package.jsonresolutions:**/handlebars4.7.9 → 4.7.10yarn.lock: the single handlebars entry re-resolved to 4.7.10handlebars is only reached through
grpc_tools_node_protoc_tsandspectaql(dev/codegen). No runtime code imports it.Verification
yarn audit --level criticalexit code 30 before, 14 after (CI fails at >=16).Unblocks #518 (ENG-640), whose only failing check is Audit.
🤖 Generated with Claude Code
https://claude.ai/code/session_01G4SaLJF5SWq6sjBEaWJFow