Various Cuda/FFI Memory Lifecycle Fixes - #257
Merged
Merged
Conversation
alan-george-lk
requested review from
a team and
xianshijing-lk
as code owners
September 8, 2026 19:57
stephen-derosa
approved these changes
Sep 8, 2026
Contributor
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🐛 1 issue in files not directly in the diff
🐛 Concurrent shutdown leaks FFI resources
A request storing a handle after dispose snapshots the map escapes cleanup. store_handle does not synchronize with disposal. The resource survives until another shutdown or process exit.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in livekit-ffi/v0.12.77, fixing the following issues:
NVIDIA encoder/decoder factories tear down a shared CUDA context on last drop, and NVENC init failures no longer leave a half-initialized encoder