Skip to content

set-test-tokens: use env vars as default for secret/key/url #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephen-derosa wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

set-test-tokens: use env vars as default for secret/key/url #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/set-test-tokens.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,14 @@ if [[ $# -ne 0 ]]; then
_fail "this script is hard-coded and does not accept arguments" 2
fi

LIVEKIT_API_KEY="devkey"
LIVEKIT_API_SECRET="secret"
LIVEKIT_API_KEY="${LIVEKIT_API_KEY:-devkey}"
LIVEKIT_API_SECRET="${LIVEKIT_API_SECRET:-secret}"
LIVEKIT_URL="${LIVEKIT_URL:-ws://localhost:7880}"
LIVEKIT_VALID_FOR="99999h"
LIVEKIT_URL="ws://localhost:7880"
_grant_json='{"canPublish":true,"canSubscribe":true,"canPublishData":true}'

echo "set_test_tokens: Using LIVEKIT_URL: $LIVEKIT_URL" >&2

@alan-george-lk alan-george-lk Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we avoid printing here? We have plenty of logs across SDK layers/end products (ROS Portal) that log which URL is being connected to. I also run individual tests often and call into this script first, so I'll be getting more output

@stephen-derosa stephen-derosa Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some log to indicate the creds being used so we can prevent devs from using the wrong creds. I could change it to "using local server" or "using cloud server" ?


if ! command -v lk >/dev/null 2>&1; then
_fail "'lk' CLI not found. Install: https://docs.livekit.io/home/cli/" 2
fi
Expand Down
Loading