fix(viewer): enable navigation in the image information dialog - #181
Merged
deepin-bot[bot] merged 2 commits intoSep 9, 2026
Merged
Conversation
Forward Left and Right shortcuts from the image information dialog to the existing image navigation handlers and remove the incorrect focus call. 将图片信息窗口的左右方向键转发至现有图片切换处理,并移除错误的 焦点设置。 Log: 修复打开图片信息后无法使用左右方向键切换图片的问题 PMS: BUG-375299 Influence: 图片信息窗口打开时可使用左右方向键切图并同步刷新图片信息。
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe information dialog now owns window-scoped Left and Right shortcuts, forwards their signals to the existing image navigation handlers, and removes the incorrect focus call used during dialog display. Review the shortcut context, signal wiring, and behavior when navigation refreshes the displayed image information. Sequence diagram for image navigation from the information dialogsequenceDiagram
participant User
participant ExtensionPanel
participant LibViewPanel
participant ImageViewer
participant LibImageInfoWidget
User->>ExtensionPanel: Left or Right key
ExtensionPanel->>ExtensionPanel: previousRequested or nextRequested
ExtensionPanel->>LibViewPanel: showPrevious or showNext
LibViewPanel->>ImageViewer: navigate to adjacent image
LibViewPanel->>LibImageInfoWidget: setImagePath
LibImageInfoWidget-->>User: Refresh image information
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Update the copyright year range in files modified for BUG-375299. 更新 BUG-375299 修改文件的版权年份范围。 Log: 更新修改文件的 SPDX 版权年份 PMS: BUG-375299 Influence: 仅更新版权声明,不影响运行行为。
max-lvs
approved these changes
Sep 9, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: max-lvs, Resurgamz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening the image information dialog moves the active shortcut context away
from the viewer window, preventing the existing Left and Right window
shortcuts from switching images.
Add Left and Right shortcuts to the information dialog and forward them to
the existing image navigation handlers. Remove the incorrect
setFocus(Qt::NoFocusReason)call, which sets focus instead of clearing it.打开图片信息窗口后,主看图窗口的左右方向键快捷键失去活动窗口上下文,
导致无法切换图片。本修改在图片信息窗口中增加左右方向键处理,并将请求
转发至现有切图逻辑,同时移除错误的焦点设置。
Log: 修复打开图片信息后无法使用左右方向键切换图片的问题
Bug: https://pms.uniontech.com/bug-view-375299.html
Influence: 图片信息窗口打开时可使用左右方向键切图并同步刷新图片信息。
Verification
libimageviewerbuilds successfully.git diff --checkpasses.OnFinishPinchAnimalcompilation error intests/test_LibImageGraphicsView.cpp.Summary by Sourcery
Enable image navigation from the information dialog by forwarding its arrow-key actions to the viewer’s existing previous and next image handlers.
New Features:
Bug Fixes:
Enhancements: