lnwire: add InboundFee struct in-line within ChannelUpdate #8604

Activity

1. Roasbeef

   added

   enhancementImprovements to existing features / behaviourImprovements to existing features / behaviour

   wire protocolEncoding of messages for the communication between nodesEncoding of messages for the communication between nodes

   intermediateIssues suitable for developers moderately familiar with the codebase and LNIssues suitable for developers moderately familiar with the codebase and LN

   feesRelated to the fees paid for transactions (both LN and funding/commitment transactions)Related to the fees paid for transactions (both LN and funding/commitment transactions)

   inbound feeChanges related to inbound routing feeChanges related to inbound routing fee

   on Mar 30, 2024
2. saubyk

   added

   P1MUST be fixed or reviewedMUST be fixed or reviewed

   P2should be fixed if one has timeshould be fixed if one has time

   and removed

   P1MUST be fixed or reviewedMUST be fixed or reviewed

   on Apr 2, 2024
3. joostjager commented on Apr 4, 2024

   

   joostjager

   on Apr 4, 2024

   Contributor

   More actions

   Inbound fees are using a custom tlv id in the high range. I think this would require more flexibility in gen_tlv_types.go?
4. Roasbeef commented on Apr 10, 2024

   

   Roasbeef

   on Apr 10, 2024

   MemberAuthor

   More actions

   @joostjager good question, so we can just make entirely new definitions, if we don't want to add 40k extra lines to that file, like so:

   type tlvType50000 {}
   
   func (t tlvType50000) TypeVal() {
       50_000
   }
   
   func (t tlvType50000) tlv() {}
   
   
   type TlvType50000 = *tlvType50000

   The set up doesn't require that only the code generation be used, just that all new instnaces must be defined in the package.

   Not explcitily related, but while we're at it, we can likely simplify from tlv.TlvType5 to tlv.Type5.