Skip to content

MIN_RELAY_FEE_SAT_PER_1000_WEIGHT is inflated 16x #3438

Closed
Closed
MIN_RELAY_FEE_SAT_PER_1000_WEIGHT is inflated 16x#3438
Assignees
arik-so
Milestone
0.1.1

Description

@morehouse
morehouse
opened on Dec 3, 2024

MIN_RELAY_FEE_SAT_PER_1000_WEIGHT is used to enforce a minimum fee bump for transaction RBFs. Per Bitcoin Core policy, this should be 1 sat/vB. Instead, we're using 16 sat/vB:

rust-lightning/lightning/src/chain/chaininterface.rs

Lines 178 to 179 in 1386bef

/// Minimum relay fee as required by bitcoin network mempool policy.
pub const MIN_RELAY_FEE_SAT_PER_1000_WEIGHT: u64 = 4000;

This causes RBFs to be much larger than needed in some cases.

We should be using 250 sat/kw, or maybe 253 sat/kw if we need to worry about rounding for the incremental relay feerate.

Activity

  1. TheBlueMatt commented on Dec 3, 2024

    @TheBlueMatt
    TheBlueMatt
    on Dec 3, 2024
    Collaborator

    Oof good catch.

  2. TheBlueMatt
    added this to the 0.1 milestone on Dec 3, 2024
  3. arik-so
    self-assigned this
    on Dec 5, 2024

  4. TheBlueMatt commented on Dec 8, 2024

    @TheBlueMatt
    TheBlueMatt
    on Dec 8, 2024
    Collaborator

    If this makes 0.1, great, if it doesn't, well, its not a regression nor a new feature, it generally takes users a week or two to upgrade anyway, and we can include this in 0.1.1.

  5. TheBlueMatt
    modified the milestones: 0.1, 0.1.1 on Dec 8, 2024

  6. arik-so commented on Jan 27, 2025

    @arik-so
    arik-so
    on Jan 27, 2025
    Contributor

    #3457 is merged, so closing this.

  7. arik-so
    closed this as completedon Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions