Skip to content

Onion message follow-ups  #1607

Open
Open

Description

@valentinewallace
  • Force users to use path_id
  • Enable the addition of dummy blinded hops for increased privacy
  • On creation, pad blinded route hops to be equal length
  • Support 1-hop blinded paths
  • Rate limit based on channel vs non-channel peers
  • Rate limit based on outbound peer buffer limits
  • Refuse to send onion messages to offline peers and drop forwards to offline peers
  • Config option for forwarding over channels-only
  • Custom TLVs, sending-side + handler on receiving side
  • Implement BOLT spec test vectors
  • Consider setting max number of hops before refusing to send
  • Custom get_route for finding an OM path (current get_route has a lot of custom stuff for payments)
  • Flip on OM feature bit (may want to conditionally flip based on whether a user has an OnionMessenger)
  • Refactor onion_utils::construct_onion_packet_with_init_noise to take one Vec instead of two
  • Minor: make onion_utils::decode_next_hop private, see Onion messages v1 #1503 (comment)
  • Add fuzz testing
  • Don't disconnect peers on garbage onion messages (cc Onion messages v1 #1503 (comment))

Activity

  1. TheBlueMatt commented on Jul 11, 2022

    @TheBlueMatt
    Collaborator

    Support receiving onion messages to phantom nodes.

  2. valentinewallace commented on Jul 14, 2022

    @valentinewallace
    ContributorAuthor

    Support receiving onion messages to phantom nodes.

    cc #1503 (comment)

  3. TheBlueMatt commented on Jul 20, 2022

    @TheBlueMatt
    Collaborator

    Need to have a fuzzer for reading/decoding/forwarding onion messages before we can ship it, I think.

  4. TheBlueMatt commented on Aug 3, 2022

    @TheBlueMatt
    Collaborator

    Maybe clean up API a bit, re #1503 (comment)

  5. valentinewallace commented on Aug 3, 2022

    @valentinewallace
    ContributorAuthor

    Due to recent spec updates forcing the use of blinded paths, we'll want to support 1-hop blinded paths now too.

  6. carlaKC commented on May 23, 2023

    @carlaKC
    Contributor

    If nobody is working on it, I'd like to attempt adding the OM test vectors - as requested here.

  7. TheBlueMatt commented on Jan 11, 2024

    @TheBlueMatt
    Collaborator

    We should presumably include padding (someone taking over #1771) no?

  8. valentinewallace commented on Jan 11, 2024

    @valentinewallace
    ContributorAuthor

    We should presumably include padding (someone taking over #1771) no?

    Yeah, that would be good. That's included in the issue already, if that's what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions