Repository navigation
Conversation
why: A prose table row's permalink sat at its first cell's right edge, far from the label it links, and appeared inconsistently with the section permalink. Typography also zeroes the outer padding of the first and last columns, so labels touched the table edge and the row's hover background. what: - Keep the row permalink at the end of its first cell's last line, out of flow so it neither widens the column nor wraps onto its own line - Hide it until the row is hovered, focused or targeted, with the section permalink's theme colors - Give markdown table cells a 0.75rem inline inset, first and last columns included; component tables keep their own padding - Add checkRowPermalinks to check-dev-sample.mjs and run it from the sample and full check-dev flows. Rust, tmux and Ruby tables at 1440, 768 and 390 px in light and dark must put the permalink within 0.5em of the last text line, share one inset across columns, stay quiet at rest, and appear legibly on hover, focus and target
Contributor
Author
|
Folded into #157, which now carries every fix from the 2026-10-18 review on one branch so they share one CI run, preview and deploy. This commit is on that branch unchanged. Discussion and evidence stay here. |
Contributor
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a prose table such as the "Stable identity, not name or index" table on the Rust server, session, window and pane page, each row's
¶permalink sat at the right edge of the first cell, a long way from the label it links. The first column's text also touched the table edge.Rows now show the
¶immediately after the first cell's last line of text, with a small gap, hidden until the row is hovered, focused or targeted, as the section¶behaves. Markdown table cells share one0.75reminline inset, first and last columns included.What changed
site/src/styles/global.css:.row-anchor-linkkeeps its static position at the end of the cell's last line and leaves the flow, so it never widens the column or wraps onto its own line (a--expand-environmentflag wrapped at 390px in an in-flow version). It uses the section permalink's theme colors and the row's:hover,:targetand:focus-withinreveal that.row-label-linkalready uses.utilitieslayer. A rule on.prose table:not([class])in that layer, the way the heading overrides do it, replaces it. Component tables carry a class and keep their own padding.site/scripts/check-dev-sample.mjs:checkRowPermalinks, run bycheckDevSample(--sample) and by the fullcheck-dev.mjsflow. It loads the Rust, tmux and Ruby workspace CLI tables in light and dark at 1440, 768 and 390px and checks every anchored row::targetwith at least 3:1 contrast against what is behind it.CONTRIBUTING.mdlists row permalinks among the browser checks.Verification
origin/mainCSS with the named failure on all three pages, for examplerow "Session" permalink starts 39.8px after its text(Rust and tmux) androw "--json" permalink starts 100.7px after its text(Ruby). With only the¶rule applied and the cell inset removed, it fails onfirst-column text sits 0.0px from the cell edge. It passes with this change, in Chromium, Firefox and WebKit.transports, TypeScriptqueries, Pythonoptions-and-hooks, Rustbatching-commands): 46 rows on seven pages in all.pnpm run lintis clean.site/test/row-anchors.test.ts,prose-markdown.test.ts,declaration-body-spacing.test.tsandheader-pickers.test.tspass (100 passed, 4 skipped); twoprose-markdownlink tests hit vitest's 5s timeout while the host's load average was above 90 and pass with--testTimeout=120000.Not run
node site/scripts/check-dev.mjs --sampledid not get past its first step.checkPickerFilterstimes out on its 5spage.gotoof/demo/widgets/pickers/on this host (load average 50 to 110) before reaching the new check. That step does not touch this change, and it failed the same way with theorigin/mainstylesheet. The wiring is checked bynode --checkand by importing the module; the check itself ran against a static page that renders the same Markdown throughrehypeRowAnchorswith this branch's compiled stylesheet, and against the Rust page in a live dev server before it was stopped._site, which was not built. The visual baseline pages (API reference pages) contain no.prosetables.