Repository navigation
Balance API card spacing and preserve contents scroll - #149
Merged
Merged
Conversation
Let declaration padding own the first Description or Examples edge. Preserve later headings, prose, examples and compact metadata spacing.
why: Moving focus into or back from the contents drawer should preserve
the document reading position, as the navigation drawer already does.
what:
- Request preventScroll for both contents drawer focus transfers.
- Check the real hub and MCP drawer transfers in the existing fixture.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API cards that begin with Description or Examples add the heading margin above the card padding. Let the card padding own that first edge while preserving later headings and compact metadata spacing.
The compact contents drawer now moves and restores keyboard focus without scrolling the document. This keeps its existing focus behavior while avoiding a focus-induced page jump.
Validation: the spacing regressions pass; the drawer fixture passes 58/58, including two new cases that fail before the change. The complete source outer loop passes in 49.04 seconds with the fresh-source browser sample on the shared preview port. A cold isolated worktree reached the unchanged 60-second deadline; that result is retained. Assembled-output checks are excluded by the source-only loop. Full browser recollapse and toolbar-occlusion findings remain open; no production closure is claimed.