Repository navigation
Restore glossary contents, keyboard tabs and source links - #148
Merged
Merged
Conversation
why: Generated declarations link to embedded raw source routes, so requiring their paths in Git rejects valid JVM source links. what: - Validate embedded source text, canonical paths and line bounds - Retain commit, public remote, path and line checks for Git links
why: TypeScript and Julia catalog source links no longer match the reviewed API model pins, so the ordinary freshness check fails. what: - Regenerate advertised revisions and mapped registration lines. - Preserve captured runtime contracts and use generator port ordering. Validation: unchanged ordinary generator fails before and passes after with all ten genuine captured-source checkouts. Runtime capture unchanged.
why: Core glossaries omit page contents and both glossary layout paths omit heading permalinks. what: - Guard actual core and DocsLayout output with strict expected failures - Retain native catalogs, contextual targets and the API browse tree
why: Core glossaries had no owner-derived page navigation, and the shared glossary headings omitted permalink controls. what: - Derive both layout outlets from the filtered native glossary metadata - Keep wide contents and native narrow links beside the API browse tree - Share adjacent heading controls and measured fragment clearance
why: Both real glossary layout paths now render their required controls. what: - Remove the strict expected-failure markers after source isolation - Load the shared heading styles in the existing parameter fixture
why: Astro rejects href on an untyped compound selector. what: - Use the Happy DOM anchor type without changing runtime assertions
why: Home and End leave package manager and language tabs unchanged. what: - Exercise the rendered component and its client script with strict failures. - Cover focus, saved choices and synchronized widget instances. - Preserve arrow, other-key and single-tab behavior.
why: The shared tab handler ignored edge keys, leaving NuGet managers and language choices unchanged. what: - Select the first or last tab through the existing focus and sync path. - Retain arrow wrapping and single-tab and other-key handling.
why: Edge keys now select and focus the first and last tabs. what: Run the component regressions without expected-failure markers, including persisted choices and cross-instance synchronization.
Exercise emitted product and hub controls through the responsive handoff, including native details and the actual drawer lifecycle. Strict expected failures retain the missing 64rem to 80rem channel.
Keep DocsLayout contents controls and fallback available until the 80rem desktop column replaces them. Navigation retains its 64rem handoff and reference/native contexts keep their existing cutoff. Close only an open sidebar at its breakpoint so it cannot release the scroll lock owned by the contents drawer.
Require one contents entry across the product and hub handoff, including native details and drawer cleanup at the desktop boundary.
why: Happy DOM's Element result omits HTML drawer properties. what: - Use the existing native HTMLElement type at fixture lookups. - Preserve emitted JavaScript and all runtime checks.
tony
changed the title
tony
marked this pull request as ready for review
October 17, 2026 05:08
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core API glossaries gain contents navigation and heading permalinks from each port’s native definitions. Shared documentation contents stay available between the sidebar and wide contents breakpoints, with keyboard dismissal, focus return and resize cleanup. Package-manager tabs support Home and End alongside arrow keys.
Generated JVM source auditing validates embedded text and declaration locations, and ordinary MCP catalog metadata matches its pinned API source. The test-only Happy DOM annotations preserve byte-identical emitted JavaScript.
Validation:
pnpm testpasses at this exact commit in 57.05 seconds under the unchanged 60-second cap, including type-check, focused suites, generated-data/link checks and the fresh-source browser sample. Source changes have independent reviews; existing source-only skips remain explicit.Hosted CI for this head and focused glossary/contents browser, assembly and public acceptance remain pending.