fix: rank multi-pattern matches by directed distance - #18
Draft
lettertwo wants to merge 1 commit into
Draft
Conversation
With more than one pattern, `closest()` picked the candidate with the smallest absolute distance to the cursor. When the cursor sits on a pattern's only occurrence, the wrapped `searchpos` reports that same match again at distance 0, so it beat every other pattern's real next/previous match and `next`/`previous` never left it. Directed searches now score each candidate by distance in the direction of travel, with a match on the wrong side of the cursor costing the full wrap, so a same-position match always loses to another pattern's genuine match. The undirected nearest-match case keeps the absolute measure. The `marked` retry loop in `match_cursor` also ranked against the stale pre-loop position, since `Cursor:move()` does not update `cursor.location`; it now ranks from the match it just moved to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With more than one pattern,
closest()picked the candidate with thesmallest absolute distance to the cursor. When the cursor sits on a
pattern's only occurrence, the wrapped
searchposreports that samematch again at distance 0, so it beat every other pattern's real
next/previous match and
next/previousnever left it.Directed searches now score each candidate by distance in the direction
of travel, with a match on the wrong side of the cursor costing the
full wrap, so a same-position match always loses to another pattern's
genuine match. The undirected nearest-match case keeps the absolute
measure.
The
markedretry loop inmatch_cursoralso ranked against the stalepre-loop position, since
Cursor:move()does not updatecursor.location; it now ranks from the match it just moved to.Stack created with GitHub Stacks CLI • Give Feedback 💬