-
Notifications
You must be signed in to change notification settings - Fork 7
[DO NOT MERGE]Open sync pull requests when a consumer's automation.yml drifts #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akolson
wants to merge
16
commits into
main
Choose a base branch
from
sync-automation-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+794
−2
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
73db4e2
Open sync pull requests when a consumer's automation.yml drifts
akolson a4ebeda
Request a pre-review from rtibblesbot on sync pull requests
akolson 06b3ee1
Fix the sync state machine and cover it with tests
akolson 3a7e81d
Fail toward drift when the template history cannot be read
akolson 4cc6deb
Say what the problem-state test guards against
akolson ecf5a25
Let a consumer supply the whole sync pull request body
akolson f25c460
Drop the bot pre-review from sync pull requests
akolson 91ad2c1
Correct what the sync states mean and what onboarding needs
akolson d4714c7
Name the bot app and tidy the sync section
akolson 042cb6d
Drop the redundant comment on the kolibri-design-system entry
akolson 1df6628
Discover the consumers instead of listing them
akolson 82b1c72
Build the pull request body from the consumer's own template
akolson 2a700c6
Treat kolibri-design-system as the one template exception
akolson 2638860
Move the marker comment to the filter that uses it
akolson c2f51ea
Contain a thrown read during discovery, and trim the kolibri-design-s…
akolson cfc4adc
Keep the explanation when a kept heading is renamed
akolson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: Sync automation template | ||
| run-name: Open a pull request in every consumer repo whose automation.yml has drifted | ||
| on: | ||
| schedule: | ||
| - cron: "17 6 * * 1" | ||
| workflow_dispatch: | ||
| inputs: | ||
| dry_run: | ||
| description: 'Report drift without opening pull requests' | ||
| type: boolean | ||
| default: false | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - automation-template.yml | ||
| permissions: | ||
| contents: read | ||
| concurrency: | ||
| group: sync-automation-template | ||
| cancel-in-progress: false | ||
| jobs: | ||
| sync: | ||
| name: Sync consumers | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Generate App Token | ||
| id: generate-token | ||
| uses: actions/create-github-app-token@v3 | ||
| with: | ||
| app-id: ${{ secrets.LE_BOT_APP_ID }} | ||
| private-key: ${{ secrets.LE_BOT_PRIVATE_KEY }} | ||
| owner: learningequality | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: '20' | ||
| cache: 'yarn' | ||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| - name: Sync consumers | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }} | ||
| run: node scripts/sync-automation-template.js ${{ inputs.dry_run && '--dry-run' || '' }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Resolved — addressed in the current code.
nitpick: Two overlapping runs can both try to open the sync PR, and the loser reports a 422. A push to
maintouchingautomation-template.ymlcan start while the weekly cron is still running. Both see no open PR and bothPOST /pulls.Please add
concurrency: { group: sync-automation-template, cancel-in-progress: false }.