Skip to content

Multi-target contracts projects (v10) - #892

Merged
Saancreed merged 3 commits into
v10.0from
contracts-multi-target-v10
Sep 10, 2026
Merged

Saancreed merged 3 commits into
v10.0from
contracts-multi-target-v10

Conversation

@Saancreed

Copy link
Copy Markdown
Member

Plus a minor fix to VersionSupport, see the commits. Allows one to stop depending on long-deprecated net6.0 TFM.

I'll port this to v11 branch afterwards.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The multi-targeting configuration and authorization annotation are consistent and complete.

Pull request overview

Enables contract packages to provide framework-specific assets for supported .NET versions while correcting authorization metadata.

Changes:

  • Multi-targets contract projects across .NET 6, 8, 9, and 10.
  • Enables the analyzer for all targets except netstandard2.0.
  • Explicitly permits unauthenticated version-support queries.
File summaries
File Description
src/Directory.Build.props Broadens analyzer inclusion across target frameworks.
src/CQRS/LeanCode.CQRS.Annotations/LeanCode.CQRS.Annotations.csproj Adds multi-targeting.
src/Infrastructure/LeanCode.ForceUpdate.Contracts/LeanCode.ForceUpdate.Contracts.csproj Adds multi-targeting.
src/Infrastructure/LeanCode.ForceUpdate.Contracts/VersionSupport.cs Marks the query as publicly accessible.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
932 931 0 1 0 0 1m 51s

Skipped

Tests Status
LeanCode.Azure.Tests.AzureStorageAuditLogIntegrationTests.Ensure_that_all_logs_are_correctly_uploaded_to_multiple_files skipped ⏭️

🎉 No failed tests in this run.

Github Test Reporter by CTRF 💚

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.12%. Comparing base (2106676) to head (ca2471a).

Additional details and impacted files
@@           Coverage Diff           @@
##            v10.0     #892   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files         241      241           
  Lines        5095     5095           
  Branches      362      374   +12     
=======================================
  Hits         4337     4337           
  Misses        675      675           
  Partials       83       83           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/Directory.Build.props
Include="../../Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.csproj"
Condition="'$(MSBuildProjectName)' != 'LeanCode.CodeAnalysis'
And '$(TargetFramework)' == 'net9.0'"
And '$(TargetFramework)' != 'netstandard2.0'"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only not the particular version of netstandard is enough here? 🤔 2.1 is fine?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, netstandard2.1 is fine because our CodeAnalysis package itself targets netstandard2.1. Only referencing it in projects targeting older netstandards is a problem.

@Saancreed
Saancreed merged commit dd78da7 into v10.0 Sep 10, 2026
9 checks passed
@Saancreed
Saancreed deleted the contracts-multi-target-v10 branch September 10, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants