Read the syntax around a reference from selection ranges by PiotrRogulski · Pull Request #55 · leancodepl/ciach

PiotrRogulski · 2026-09-17T09:13:34Z

textDocument/selectionRange returns the syntax nodes enclosing a position, innermost first, many positions per request. Nodes have ranges but no kinds, so "this is a case clause" is checked by the node's first semantic token.

LspClient.selectionRanges and a per-position cache; the finder fetches the positions the checks need before classification, one request per file.
isPatternRef: the type heads a pattern whose parent opens with case, or starts a switch-expression arm whose parent opens with switch.
isDotValuesRef / enumIteratesOwnValues: the reference and values form one node; a bare values starts its own expression.
isRedirectingFactory: the last token's chain reaches the declaration without crossing a body node.
Removed the bracket matching behind all of these. lexing.dart still backs two constructor checks (next PR).

Same verdicts on the fixture package. A position without a chain reads as "not the special shape", which keeps code.

🤖 Generated with Claude Code

https://claude.ai/code/session_0146xh6qZsHDegsCAoRBEqwz

textDocument/selectionRange returns the syntax nodes enclosing a position, innermost first. Use them for type patterns, Enum.values iteration, a bare `values` in an enum body, and redirecting factories, instead of matching brackets in ciach's own token stream. The finder fetches the ranges it needs before classification, one request per file. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146xh6qZsHDegsCAoRBEqwz

PiotrRogulski mentioned this pull request Sep 17, 2026

Ask the server about superclasses and retire the lexer #56

Merged

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from 34eb050 to 317308f Compare September 17, 2026 09:29

This was referenced Sep 17, 2026

Read declaration ranges and kinds from the server outline #53

Merged

Read comments, annotations and modifiers from semantic tokens #54

Merged

PiotrRogulski added this pull request to stack #57 September 17, 2026 09:35

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from 317308f to 40cb9c6 Compare September 17, 2026 10:16

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from 40cb9c6 to 56cadbe Compare September 17, 2026 10:37

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from 56cadbe to b48d104 Compare September 17, 2026 10:38

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from b48d104 to 6a7fe10 Compare September 17, 2026 10:39

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from 6a7fe10 to 7423770 Compare September 17, 2026 11:42

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from 7423770 to 9ab37da Compare September 17, 2026 11:44

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from 9ab37da to 9fa3749 Compare September 17, 2026 11:49

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch 2 times, most recently from 8fc12c4 to 0f2b828 Compare September 17, 2026 11:55

PiotrRogulski force-pushed the claude/quirky-hawking-jdfvsx-3-selection-ranges branch from 0f2b828 to 1afdca5 Compare September 17, 2026 12:08