Add visual examples to README and fix validation on landing website - #81
Merged
Merged
Conversation
The toy `isEmail` every example carried only looked for an '@', so the sign-up demo on the landing page accepted `ada @example.com` — spaces and all. Albert typed one in and it sailed through, which is a poor look for a validation library's first impression. Every copy now matches a pattern instead: no whitespace, one '@', a dot in the domain. The custom-validators page builds `isEmail` on top of its own `matches` helper, so the composition it teaches does the work, and the subform examples share one top-level pattern rather than an inline `contains`. Verified in a browser against the live islands: `ada @example.com`, `ada@example` and `ada` are all rejected, `ada@example.com` passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Piotr's review, in three parts. The opening paragraph led with the architecture. It now leads with what you get — simple and complicated forms wired the same way, validation and async checks in the box — and keeps the technical sentence, and its search keywords, right underneath. 'Your first form' dropped three unlabelled code blocks in a row. Each one now says what it is: the form controller, the form widget, the field widget. And the wall of text got pictures, taken from the live examples that are compiled from these very snippets: the first form after an empty submit, a username rejected by a server-side check, and a guest list where each guest is a subform added at runtime. Each links to its live version. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
KamilSztandur
requested review from
PiotrRogulski and
mateusz-pietras
as code owners
September 11, 2026 08:43
|
Docs preview: https://advanced-forms-njq6gz8u6-leancode.vercel.app Built from 6c9bec1; the landing page is at |
mateusz-pietras
approved these changes
Sep 11, 2026
mateusz-pietras
left a comment
Member
There was a problem hiding this comment.
lgmt, check that one png tho
Documentation only: the README rewrite and the e-mail validator fix in the examples, so pub.dev picks them up. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The crop was taken in page coordinates after the island had been scrolled into view, so it landed a viewport's worth too high: the example's title bar at the top, the button sliced at the bottom. It is an element screenshot now, cut under the last row the lime button fills. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sign-up demo accepted
ada @example.comThe
isEmailevery example carried wasvalue.contains('@'), so the first form a visitor touches on the landing page let spaces through. Not a great first impression for a validation library.Every copy now matches a pattern — no whitespace, one
@, a dot in the domain — in the landing hero, the custom-validators page (built on its ownmatcheshelper, so the composition it teaches does the work), server errors, both subform examples, and the example app. The test snippet in the testing docs gained the whitespace case.Verified in a browser against the live islands:
ada @example.comada@exampleadaada@example.comREADME
The logo geometry Piotr also raised is left alone — a designer is on it.
Release
0.2.1+1, documentation only, no library changes. Version bumped inpubspec.yaml,example/pubspec.yamland the example lockfile, with aCHANGELOG.mdentry.Checks
flutter analyzeandflutter test(39) in the package and the island bundle,dart format,examples:check,examples:format:check,types:check,lint,format,next build, and a pass over every page whose snippet changed to confirm its island still comes up clean.panareports 160/160 at the new version.🤖 Generated with Claude Code