spec-sync(v2): send pageSize query param and support cancelled extract status - #164
Open
yzld2002 wants to merge 2 commits into
Open
spec-sync(v2): send pageSize query param and support cancelled extract status#164yzld2002 wants to merge 2 commits into
pageSize query param and support cancelled extract status#164yzld2002 wants to merge 2 commits into
Conversation
![spec-sync[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The PR explicitly requires human review before merge despite being a valid mechanical-only synchronization.
Pull request overview
Updates the mirrored V2 OpenAPI snapshot and regenerated reference models to track upstream specification drift.
Changes:
- Refreshes the V2 specification snapshot.
- Regenerates reference Pydantic models from that snapshot.
File summaries
| File | Description |
|---|---|
specs/v2-aide.json |
Updates the upstream V2 specification snapshot. |
specs/_generated/v2_models.py |
Regenerates reference models from the updated specification. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
yzld2002
changed the title
pageSize query param and support cancelled extract status
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The documentation overstates cancelled-status behavior for wait(), and the live pagination test can pass without verifying the parameter.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 4
- Review effort level: Balanced
Comment on lines
+214
to
+219
| jobs = ( | ||
| staging_client.v2.parse_jobs.list(page=0, page_size=1) | ||
| if resource == "parse" | ||
| else staging_client.v2.extract_jobs.list(page=0, page_size=1) | ||
| ) | ||
| assert len(jobs) <= 1 |
| - <code>client.v2.extract_jobs.<a href="./src/landingai_ade/resources/v2/extract.py">wait</a>(job_id, \*, timeout=600, poll_interval=None, raise_on_failure=False) -> <a href="./src/landingai_ade/types/v2/job.py">Job</a></code> | ||
|
|
||
| Same polling/timeout semantics as `parse_jobs.wait`. Extract jobs have no `cancelled` status, so `raise_on_failure` only ever triggers on `failed`. | ||
| Same polling/timeout semantics as `parse_jobs.wait`. `cancelled` is a terminal extract status (the list-jobs envelope reports it alongside `pending` / `processing` / `completed` / `failed`), so waiting stops on it like any other terminal state. |
Comment on lines
+179
to
+182
| (`test_extract_job_list_normalizes_cancelled_status` in | ||
| `tests/api_resources/v2/test_extract.py`) proving the value survives | ||
| normalization and counts as terminal, so `wait()` stops on it instead of polling | ||
| to its deadline. |
Comment on lines
+307
to
+309
| set and the job ends failed/cancelled with an error attached. `cancelled` | ||
| is a terminal extract status (the spec added it to the list-jobs envelope | ||
| on 2026-09-10), so waiting stops on it like any other terminal state. |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated V2 spec-sync PR (
client.v2).Gates (surface-lock, V2 contract tests, lint/test/typecheck) must pass. When present, the AI commit is a draft a human finishes (the V2 ergonomic layer — unified Job, dual-host, schema coercion — is not in the spec). Human review required before merge.
What changed
AI-generated from the PR diff — verify against the actual changes.
This PR updates the V2 job-listing query parameter to match the gateway's wire naming and adds
cancelledas a recognized terminal status for extract jobs.Changes:
page_sizekeyword onparse_jobs.list,extract_jobs.list, andbuild_schema_jobs.list(sync and async) is now sent on the wire aspageSize, with no change to the public kwarg name or the response'spage_sizefield.extract_jobs.waitnow treatscancelledas a terminal status (in addition tocompleted/failed), since the extract list-jobs envelope can report it.output_save_urlis now shared between the async extract wire contract and/api/extract, alongside spec description updates for split-documentfilenamebehavior onmarkdownfile uploads.