fix: do not dump both class and class_ on Split - #148
Open
BetterAndBetterII wants to merge 1 commit into
Open
Conversation
construct() was storing the API alias as an extra after filling class_, so model_dump_json emitted both keys and S3 JSON with class_ failed validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64.
Split.class_is aliased toclass.construct()treated the alias as an extra field, somodel_dump_json()emitted bothclassandclass_. JSON that only hadclass_then failed validation unlessby_name=True.Consumed aliases are no longer stored as extras, and models can also be populated by field name. Dump now emits one key; dumped JSON round-trips.
Test plan
pytest tests/test_parse_response.py tests/test_models.py::test_aliased_field_not_duplicated_in_dump tests/test_models.py::test_validate_aliased_field_by_name