Repository navigation
Refuse a form with more distinct sections than letters [patch] - #427
Merged
Merged
Conversation
Form.Of labelled the 27th structurally distinct section '[', which Form.Parse rejects, so Parse(ToString()) failed for a Form the library produced. Of now throws ArgumentException past 26 distinct sections, exposed as Form.MaxDistinctSections. Fixes #314 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SWJoWcEC3BuVS7pSPco7mA
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #314
What changed
Form.Ofgave each structurally distinct section the letter'A' + indexwith no upper bound. The 27th distinct section was labelled'[', whichForm.Parserejects, soParse(ToString())failed on aFormthe library had produced.This takes the fail-fast option from the issue, which triage named as the smaller change:
Form.OfthrowsArgumentExceptionwhen an arrangement has more than 26 structurally distinct sections.Form.MaxDistinctSectionsand documented onForm.OfandArrangement.Form.Tests
FormTestsgains three cases:A–Z, and the result round-trips throughParse.mainwith "no exception was thrown".A–Zfollowed byA.All 354 Music tests pass. The local Sonar build reports nothing in the changed files.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SWJoWcEC3BuVS7pSPco7mA
Generated by Claude Code