Repository navigation
Trim the semantic Command constructor's name, description and category [patch] - #186
Merged
Merged
Conversation
…y [patch] The semantic-type constructor trimmed only the id, so a padded category was stored as given and GetCommandsByCategory, which trims its input, never found it until a save and reload. It now normalizes the same way the string constructor does: name, description and category are trimmed, a blank description or category becomes null, and a blank name is refused. Fixes #146 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CCikcgWw27K5y1T5jxpzcG
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146
What changed
Command(CommandId, CommandName, CommandDescription?, CommandCategory?)trimmed only the id (#123). A padded category was stored as given, soGetCommandsByCategory, which trims its input, never found the command until a save and reload. The constructor now normalizes the same way the string constructor does. Both constructors use oneTrimToNullhelper:nullArgumentException, which is what both constructors' docs already sayTests
SemanticCommandNormalizationTests: padded values are trimmed, blank values become null, a blank name throws, the result matches the string constructor's, andGetCommandsByCategory("Editing")finds the command without a reload.Generated by Claude Code