Conversation
Add sks-service-ip-family-policy and sks-service-ip-families to config-network. Both keys must be set together; values are validated against the Kubernetes Service ipFamilyPolicy/ipFamilies semantics (ordered dual-stack supported, SingleStack requires exactly one family). Invalid or partial configuration is rejected.
|
Welcome @aqeelat! It looks like this is your first PR to knative/networking 🎉 |
|
Hi @aqeelat. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aqeelat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 participant
Adds two new config-network keys that control spec.ipFamilyPolicy and spec.ipFamilies on the K8s Services created for ServerlessServices:
Each key is optional, matching the Kubernetes Service semantics: an unset key leaves the corresponding ServiceSpec field empty for the apiserver to default. Set values are validated against the Kubernetes rules — unknown policies/families and duplicate families are rejected, and an explicit SingleStack policy takes exactly one family. Dual-stack policies accept one or two families; the apiserver adds the alternate family when only one is given.
The parsed Config fields (SKSServiceIPFamilyPolicy / SKSServiceIPFamilies) are consumed by the SKS reconciler in knative/serving; the consuming change lands separately against this module bump.