Skip to content

Clarify authenticator requirement outcome - #529

Merged
masnwilliams merged 1 commit into
mainfrom
hypeship/clarify-totp-required
Aug 31, 2026
Merged

Clarify authenticator requirement outcome#529
masnwilliams merged 1 commit into
mainfrom
hypeship/clarify-totp-required

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

summary

  • describe totp_required without inferring whether the attached credential contains a TOTP secret
  • align the public recovery table with the deployed, provider-agnostic managed-auth outcome

validation

  • bunx mintlify broken-links

Note

Low Risk
Documentation-only wording change with no runtime or API impact.

Overview
Updates the totp_required row in the connection lifecycle failure-code table so it describes the observed outcome (reauth needed an authenticator code Kernel could not supply automatically) instead of implying the linked credential is missing a TOTP secret.

This keeps public docs aligned with provider-agnostic managed-auth behavior and avoids misleading readers when TOTP is present but still not usable in unattended reauth.

Reviewed by Cursor Bugbot for commit 626d354. Bugbot is set up for automated code reviews on this repo. Configure here.

@mintlify

mintlify Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Kernel 🟢 Ready View Preview Aug 31, 2026, 1:35 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk assessment: Very Low

Verdict: Approve.

This PR changes one sentence in auth/connection-lifecycle.mdx. The totp_required row in the connection-lifecycle failure-code table is reworded from implying a missing TOTP secret to describing the observed outcome (an authenticator code Kernel could not supply automatically).

Why Very Low

  • Documentation-only: one file, one line, no code, config, or infrastructure changes
  • No production logic, API surface, auth implementation, or shared systems modified
  • Blast radius is limited to public docs copy for an existing failure code
  • No CODEOWNERS file in this repo, so code-owner review is not required
  • No prior approval to re-evaluate

Safe to approve.

Open in Web View Automation 

Sent by Cursor Automation: Assign PR reviewers

@masnwilliams
masnwilliams merged commit 5574cb5 into main Aug 31, 2026
4 checks passed
@masnwilliams
masnwilliams deleted the hypeship/clarify-totp-required branch August 31, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant