validateLineBreak() function in CSV File does not check for Mac Line Breaks #29

Open

opened

on May 15, 2018

It is not clear why Mac line breaks are allowed at

https://github.com/keboola/php-csv/blob/eb77f51e22d3e13a8e14a5d5a0b588cf9e8c56c5/src/CsvFile.php#L183-186

yet they are not included in the validation at

php-csv/src/CsvFile.php

Line 408 in eb77f51

if (in_array($lineBreak, ["\r\n", "\n"])) {

ssmusoke
added a commit that references this issue on May 15, 2018
keboola#29 Enable MacOS Line breaks as acceptable
6bbd4b0
ssmusoke commented on May 15, 2018
ssmusoke
on May 15, 2018
Author
PR #30

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests