fix(byo): persist sessions across actor suspension - #2926
Open
Dragonzz27 wants to merge 2 commits into
Open
Dragonzz27 wants to merge 2 commits into
Dragonzz27 wants to merge 2 commits into
Conversation
Signed-off-by: Dragonzz27 <82201310+Dragonzz27@users.noreply.github.com>
EItanya
reviewed
Sep 24, 2026
| return nil, err | ||
| } | ||
| template, harness := input.Root.Template, input.Harness | ||
| compiled.Config.SessionDBURL = "sqlite+aiosqlite:////data/sessions.db" |
Contributor
There was a problem hiding this comment.
Why is this not being set in c.config.Build?
Contributor
Author
There was a problem hiding this comment.
Good point. I moved the session DB URL into adkconfig.Build, removed the duplicate assignments from both compilers, and added a builder test.
Signed-off-by: Dragonzz27 <82201310+Dragonzz27@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2921
Set the BYO compiler's session_db_url to /data/sessions.db, matching the kagent compiler. The Go ADK can then keep session state in the actor's durable directory instead of memory.
The compiler test checks the generated URL, and the existing BYO checkpoint E2E is no longer skipped.
Validation: gofmt -d and git diff --check passed. Go unit tests and Kind E2E were not run locally because the module cache could not be completed and Kind/Docker are unavailable.