chore: update readme to mention sha-1 header format - #66
Elbarae1921 wants to merge 1 commit into
Conversation
|
Thank you, @Elbarae1921 — and thanks to @dend456, whose comment on #60 you cited. You were right that this is a real trap: One refinement in #73: Google documents the value as Base16 (hex), and case is not significant — only the colons have to go. So rather than "lowercase with colons removed", the README now reads: // Base16 (hex) SHA-1 of the signing certificate, colons stripped.
// keytool prints AA:BB:CC:... — remove the colons. Case does not matter.
'X-Android-Cert': '00112233445566778899AABBCCDDEEFF00112233',Your PR also led me to a worse problem in the same block, which I would not have looked at otherwise: the surrounding snippet passed Every code block in the README is now compiled in CI ( Closing as superseded by #73, with the credit yours. Thanks for taking the time to document something that had already cost you the afternoon. |
|
#73 is merged and released as 4.0.0, carrying your change with credit — see the detailed comment above. Closing as superseded, not rejected. Thanks again. |
Hello, thanks for this great package.
I've spent several hours trying to figure out why my (restricted) API key wasn't working, turns out it was the certificate header format.
I think it would be useful to mention this in the documentation.
Thanks to @dend456's comment.