1.0.1: programmatic phone changes, shared error tracker, reset grace - #10
Merged
Merged
Conversation
…grace - Changing the country from code (prefill, reset, a detected international number), toggling formatInput, replacing the country lists, or prefilling "+1..." while the phone field is shown no longer logs "setState() or markNeedsBuild() called during build". The field gets a fresh mirror controller when flutter_intl_phone_field 0.1.1 is about to rewrite it mid-build, and only then, so a host rebuilding with a new list instance keeps its undo history. - The screens of a FlutterAnimatedLogin share one ScreenErrorSnackBar, so a success dismisses an error shown by an earlier copy of a screen (wrong code, Edit, Continue, right code). - The post-success reset waits 150 ms of frames for the app to navigate. The form stays busy meanwhile, and a step the app opens during the wait is kept. - The keyboard's action key no longer submits while a request or the reset wait is in progress. Each has a regression test that fails before the change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- Build & Release failed on every push to main for 1.0.0: the
PERSONAL_TOKEN secret was rejected ("Invalid username or token").
The job already has contents: write, so its own token can push
gh-pages.
- The tag-triggered publish job waited indefinitely for interactive
pub.dev sign-in because automated publishing is not enabled for the
package; give it a 15-minute timeout.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes to 1.0.0, each with a regression test in
test/regression_test.dartthat fails before the change.prefill(countryIsoCode:),reset()to another country, a detected international number, togglingformatInput, replacing country lists, and prefilling+1…while the phone field is shown.flutter_intl_phone_field0.1.1 rewrites its controller fromdidUpdateWidget; the identifier field now hands it a fresh mirror controller exactly when that rewrite is coming. The root fix is in itsarvinddev/flutter_intl_phone_field (0.1.2, not yet published); this workaround keeps 1.0.1 correct on 0.1.1 and is harmless on 0.1.2.GITHUB_TOKEN(thePERSONAL_TOKENsecret was rejected, so every 1.0.0 deploy failed); the publish job now times out after 15 minutes instead of waiting for interactive sign-in.Verification
flutter test: 199 passed, both onflutter_intl_phone_field0.1.1 and with a path override to the patched 0.1.2.flutter analyze lib testanddart format --set-exit-if-changed .: clean. Example app: analyze and tests clean.Known and unchanged from 1.0.0: if the app already has two SnackBars queued, a success can hide the app's message rather than the package error. Flutter has no public API for inspecting the SnackBar queue.
🤖 Generated with Claude Code