perf(app): defer the inactive thread route - #23
Merged
Merged
Conversation
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ThreadPagethrough one cached dynamic importbeforeLoadhookWhy
Home could not use 39 modules pulled in by the static
ThreadPageimport, but every Home launch parsed them.Measured result
Verification
pnpm --filter @honk/app dev:startup-reviewfailed onthread/page.tsxbefore the split, then passed and started Vitepnpm --filter @honk/app buildRepository-wide typecheck remains blocked by the same
onboarding-layout.tsx:344 gearColossuserror on both trees. Design lint reports only the 12 legacy/v2findings already on main. The architecture check still reports the same five pre-existing oversized files.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.