Skip to content

perf(app): defer workbench Changes surface - #19

Merged
Itsnotaka merged 1 commit into
mainfrom
daniel/frontend-defer-workbench-changes
Aug 4, 2026
Merged

Itsnotaka merged 1 commit into
mainfrom
daniel/frontend-defer-workbench-changes

Conversation

@Itsnotaka

@Itsnotaka Itsnotaka commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • extract the Changes resource and badge subscription from the visual editor
  • load the Changes editor only when its workbench tab becomes active
  • share permanent root, toolbar, and loading-stage geometry with the Suspense fallback
  • extend the dev startup guard and add the performance review

Impact

  • eager app source: 1,430.7 KiB to 1,333.2 KiB, down 6.82%
  • initial production JavaScript: 2,965,273 to 2,871,162 raw bytes, down 3.17%
  • Electron window-ready median: 6,001 ms to 5,699 ms, down 5.03%
  • initial React render median: unchanged at 2.0 ms
  • first post-commit frame: 6,010.4 ms to 5,708.7 ms, 5.02% earlier

Validation

  • pnpm --filter @honk/app dev:startup-review
  • pnpm --filter @honk/app exec vitest run src/workbench-changes.test.ts
  • pnpm --filter @honk/app build
  • targeted oxfmt and oxlint
  • React Doctor changed-scope score: 88, inherited warnings only

Repo-wide app typecheck, architecture, and design checks retain their existing unrelated failures, including onboarding-layout.tsx gearColossus and v2.tsx design violations.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@vercel

vercel Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
honk-marketing Ready Ready Preview Aug 4, 2026 6:06pm

Request Review

@Itsnotaka
Itsnotaka merged commit 0732f86 into main Aug 4, 2026
4 of 5 checks passed
@Itsnotaka
Itsnotaka deleted the daniel/frontend-defer-workbench-changes branch August 6, 2026 05:46

This branch was successfully deployed

1 active deployment
Preview — a172c52a Deployed Aug 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant