perf(app): defer closed shell overlays - #17
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Itsnotaka
marked this pull request as ready for review
August 4, 2026 17:22
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
These shell-owned components rendered no visible UI during a normal Electron launch, but their full visual trees, icons, QR code path, settings rail, and toast cards were still parsed and compiled at startup.
The first open now pays one local chunk import; subsequent opens use the renderer module cache. State, dismissal, pairing resume, route mounting, and toast timers stay eager.
Performance
No release benchmark loop or UI automation was used.
Validation
pnpm --filter @honk/app dev:startup-review(0/4 closed visuals eager; Vite started)pnpm --filter @honk/app buildRepository-wide checks retain main's existing failures:
onboarding-layout.tsxreferences missinggearColossus, five files exceed the architecture limit, andv2.tsxhas design-lint findings. This PR adds no findings to those checks.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.