perf(app): defer settings panels from startup - #16
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Itsnotaka
marked this pull request as ready for review
August 4, 2026 16:47
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Itsnotaka
added a commit
that referenced
this pull request
Aug 6, 2026
Defers settings panel modules from the renderer startup graph and adds development startup measurements.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The closed Settings overlay was statically importing every panel into the renderer startup graph. Those controls are unavailable until Settings opens, and only one panel is visible at a time.
Impact
The first visit to a settings panel pays one local dynamic import. Subsequent visits use the module cache. Build configuration, allocators, and permanent startup UI are unchanged.
Validation
pnpm --filter @honk/app dev:startup-reviewpnpm --filter @honk/desktop typecheckpnpm --filter @honk/desktop test(76 passed)pnpm --filter @honk/desktop buildThe full app typecheck, app test suite, architecture check, and design lint retain failures reproduced on a clean baseline checkout: the missing
gearColossusicon type, three StyleX debug-class assertions, five existing oversized files, and existing raw-style findings inv2.tsx.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.