crc: Fix incorrect include path in gzip refl asm files. - #433
Open
thiagomacieira wants to merge 1 commit into
Open
thiagomacieira wants to merge 1 commit into
thiagomacieira wants to merge 1 commit into
Conversation
crc32_gzip_refl_avx2.asm and crc32_gzip_refl_by16_10.asm used
%include "include/crc.inc" instead of %include "crc.inc" like every
other file that includes crc.inc. The extra "include/" prefix breaks
out-of-tree builds, since nasm resolves it against the -I ../include/
search path as ../include/include/crc.inc, which doesn't exist:
crc/crc32_gzip_refl_avx2.s:54: error: unable to open include file `include/crc.inc': No such file or directory
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
force-pushed
the
crc_Fix_incorrect_include_path_in_gzip_refl_asm_files_
branch
from
September 15, 2026 16:59
32d789a to
ae8383c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crc32_gzip_refl_avx2.asm and crc32_gzip_refl_by16_10.asm used %include "include/crc.inc" instead of %include "crc.inc" like every other file that includes crc.inc. The extra "include/" prefix breaks out-of-tree builds, since nasm resolves it against the -I ../include/ search path as ../include/include/crc.inc, which doesn't exist: