Skip to content

fix: remove deprecated --txlookuplimit flag from start-op-geth.sh - #82

Open
amathxbt wants to merge 1 commit into
inkonchain:mainfrom
amathxbt:fix/remove-deprecated-txlookuplimit
Open

fix: remove deprecated --txlookuplimit flag from start-op-geth.sh#82
amathxbt wants to merge 1 commit into
inkonchain:mainfrom
amathxbt:fix/remove-deprecated-txlookuplimit

Conversation

@amathxbt

Copy link
Copy Markdown

Bug

scripts/start-op-geth.sh passes both --txlookuplimit=0 and --history.transactions=0 to geth:

  --txlookuplimit=0 \        # ❌ deprecated since geth v1.13
  --history.state=0 \
  --history.transactions=0 \ # ✅ the replacement flag

--txlookuplimit was deprecated and then removed in go-ethereum v1.13+ in favour of --history.transactions. Passing the removed flag causes:

  • Startup failure on geth builds ≥ v1.13 that have fully removed the flag (flag provided but not defined: -txlookuplimit)
  • Confusing warnings on builds that still accept it but treat it as a no-op
  • Operator confusion when reading the config, since the intent (disable tx index limit) is expressed twice with inconsistent naming

Fix

Remove the deprecated --txlookuplimit=0 line. The desired behaviour (no transaction lookup limit) is already correctly expressed by the --history.transactions=0 flag that remains.

Reference

@kutluhaneth46 kutluhaneth46 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

scripts/start-op-geth.sh currently sets both the legacy --txlookuplimit=0 and the modern --history.transactions=0. Dropping the deprecated flag is correct — --history.transactions=0 already expresses “keep full tx lookup history,” so --txlookuplimit is redundant and can warn/fail on newer op-geth builds.

LGTM.

@kutluhaneth46 kutluhaneth46 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

scripts/start-op-geth.sh currently sets both the legacy --txlookuplimit=0 and the modern --history.transactions=0. Dropping the deprecated flag is correct — --history.transactions=0 already expresses “keep full tx lookup history,” so --txlookuplimit is redundant and can warn/fail on newer op-geth builds.

LGTM from a community read of the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants